[gstreamer-bugs] [Bug 337026] oggmux doesn't set EOS properly

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=337026
 GStreamer | gst-plugins-base | Ver: HEAD CVS





------- Comment #18 from Michael Smith  2006-07-28 15:11 UTC -------
+  gboolean removed;             /* whether the pad have been removed */

   GstBuffer *buffer;            /* the queued buffer for this pad */
+  GstBuffer *next_buffer;       /* and the one after that */

'has been removed'

Also, can you change the comments on buffer/next_buffer to be clearer about
what they are, exactly? 

Not clear why you're using g_atomic_ things. If that's neccesary, then probably
it's not sufficient - you should be taking the object lock, perhaps?

You move removing the pad from collectpads from the release_pad method to the
main collectpads collected function. Why? Is this neccesary? Seems strange...

Please don't add > 80 column lines.

Recursively calling your collectpads collected function looks... ugly, and it's
really hard to convince myself that it can't get things wrong. It's just to
clear out the queues at EOS, right? Perhaps you can factor that out into
another function, and just call that.

Otherwise, the patch itself looks pretty good. I haven't checked your tests,
though.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.