[gstreamer-bugs] [Bug 349180] gst_parse_launch is not reentrant (or recursively callable)

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=349180
 GStreamer | gstreamer (core) | Ver: HEAD CVS


Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com
  Attachment #69892|commented-on                |accepted-commit_now
               Flag|                            |




------- Comment #5 from Jan Schmidt  2006-07-30 10:35 UTC -------
Looks fine to me. 

Marc-Andre: The makefile modification is needed because you removed the yylex()
wrapper that was calling the lexer method. It wasn't doing anything else
useful, so I think it's cleaner to change the makefile the way you have.

Stefan: You must be doing something wrong when you pass the stuff into
gst-parse-launch, because quoted stuff with spaces should continue to work the
same way. c.f: gst-launch fakesrc name="test 1 fakesrc" ! fakesink works the
same both with and without the patch

Lastly, there's a fixme in yyerror about placing the error into a GError, which
can be done now that the graph is being passed to yyerror. I can fix that after
you commit though if you're not sure what I mean.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.