[gstreamer-bugs] [Bug 344101] SunAudio mixer fixes

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=344101
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim at fluendo.com
  Attachment #67003|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.4




------- Comment #3 from Wim Taymans  2006-06-09 17:30 UTC -------
        Patch by: Brian Cameron <brian dot cameron at sun dot com>

        * sys/sunaudio/gstsunaudiomixerctrl.c:
        (gst_sunaudiomixer_ctrl_open), (gst_sunaudiomixer_ctrl_build_list),
        (gst_sunaudiomixer_ctrl_new), (gst_sunaudiomixer_ctrl_set_volume),
        (gst_sunaudiomixer_ctrl_set_mute):
        * sys/sunaudio/gstsunaudiosink.c: (gst_sunaudiosink_class_init),
        (gst_sunaudiosink_init), (gst_sunaudiosink_prepare),
        (gst_sunaudiosink_write):
        Attached find a patch that fixes a number of bugs with the SunAudio
mixer
        plugin and fixes #344101:
        1. The gst_sunaudiomixer_ctrl_build_list kept appending the same 3
tracks onto
           the tracklist causing gnome-volume-control's preferences dialog to
be messed
           up and would core dump if you checked/unchecked any item.
        2. We weren't previously setting the MUTE flag properly.  Fixing this
makes
           gnome-volume-control work better.
        3. Now we properly define the input track to be GST_MIXER_TRACK_INPUT
and
           the monitor to be GST_MIXER_TRACK_OUTPUT, so that makes
gnome-volume-control
           look better.
        Also some minor cleanup in gstsunaudiosink.c.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.