[gstreamer-bugs] [Bug 330317] New xingmux element for writing Xing headers

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=330317
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60992|none                        |commented-on
               Flag|                            |
          Component|gst-plugins-ugly            |gst-plugins-bad
            Summary|[lame] Add proper support   |New xingmux element  for
                   |for writing Xing headers    |writing Xing headers




------- Comment #16 from Tim-Philipp Müller  2006-03-10 13:26 UTC -------
So here goes the usual nitpicking:

 * the filenames should be gstxingmux.[ch], not gst-xing-mux.[ch]

 * the plugin name in GST_PLUGIN_DEFINE should be "xingheader" or "xing",
   and the plugin filename in Makefile.am should be libgstxingheader.so
   or libgstxing.so (the element is then still called "xingmux"). That way
   it's possible to list the plugin details separately in gst-inspect, and
   also it matches the directory naming (gst/xingheader/). Just a personal
   preference of mine though, there are plenty of cases where this isn't done.

 * Here
      const gchar mp3_header[4] = {0xff, 0xfb, 0x90, 0x44};
   you should use guint8 or guchar.

 * for elements that aren't base classes for other elements you don't
   really need private structs like GstXingMuxPriv, as the header file
   is not installed, so there aren't any ABI/API issues here. Doesn't
   hurt to have it of course, just thought I'd mention it.


Feel free to commit to -bad when you think it's ready (do change the filenames
though).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.