[gstreamer-bugs] [Bug 335365] inefficient use of GList in gst-plugins-base

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=335365
 GStreamer | gst-plugins-base | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|bad use of GList in gst-    |inefficient use of GList in
                   |plugins-base                |gst-plugins-base
   Target Milestone|HEAD                        |0.10.6




------- Comment #5 from Tim-Philipp Müller  2006-03-21 17:51 UTC -------
Fixed in CVS:

 2006-03-21  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/ogg/gstoggparse.c: (gst_ogg_parse_find_stream),
        (gst_ogg_parse_chain):
          Fix very inefficient usage of linked lists (#335365).


I don't think the strlen() cases in -good are an issue (and the compiler should
be smart enough to recognise that the string passed to it is a const string
anyway, and then take the length determined at compile time). But even if not,
the strings here are very very short, and code readability is also a factor
IMHO.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.