[gstreamer-bugs] [Bug 326998] GstBaseSrc's send_event handler ignores seek requests after pad activation

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=326998
 GStreamer | gstreamer (core) | Ver: HEAD CVS





------- Comment #2 from Wim Taymans  2006-03-27 09:04 UTC -------
Hello!

Judging from the ChangeLog, it looks like you implemented seeking in
gstbasesrc.c. May I suggest the following patch to enable seeking on
elements (not pads) that are running? 

Currently, you just store the event in data.ABI.pending_seek which is
checked in gst_base_src_activate_push. But if the pipeline is running
and  gst_base_src_activate_push has already been called, the seek will
never be performed.

Thanks a lot!

Regards

Lutz Müller

Index: gstbasesrc.c
===================================================================
RCS file: /cvs/gstreamer/gstreamer/libs/gst/base/gstbasesrc.c,v
retrieving revision 1.99
diff -u -3 -p -b -B -d -r1.99 gstbasesrc.c
--- gstbasesrc.c        8 Mar 2006 13:44:55 -0000       1.99
+++ gstbasesrc.c        24 Mar 2006 21:57:03 -0000
@@ -884,6 +884,10 @@ gst_base_src_send_event (GstElement * el
   switch (GST_EVENT_TYPE (event)) {
     case GST_EVENT_SEEK:
     {
+      if (GST_PAD_ACTIVATE_MODE (GST_BASE_SRC_PAD (src)) == GST_ACTIVATE_PUSH)
{
+        result = gst_base_src_perform_seek (src, event, FALSE);
+        break;
+      }
       GST_OBJECT_LOCK (src);
       /* gst_event_replace? */
       if (src->data.ABI.pending_seek)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.