[gstreamer-bugs] [Bug 336336] [queue] Queue might block in EOS

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=336336
 GStreamer | gstreamer (core) | Ver: 0.10.4


Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62285|none                        |committed
               Flag|                            |
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.5




------- Comment #4 from Wim Taymans  2006-03-29 11:02 UTC -------
        Patch by Tommi My��h��nen <ext-tommi dot myohanen at nokia dot
com>

        * plugins/elements/gstqueue.c: (gst_queue_init),
        (gst_queue_locked_flush), (gst_queue_handle_sink_event),
        (gst_queue_set_property):
        * plugins/elements/gstqueue.h:
        In queue, when EOS is received, if minimum threshold > max_size -
        current_level, there is chance that queue blocks forever in conditional
item
        del wait. This is because the queue is not emptied completely due to
minimum
        threshold.
        Here is another approach. Instead of setting cur_levels to max in EOS,
just
        zero all minimum threshold levels. This should make sure that queue
gives out
        all data. When going to READY (stop) state, just reset the original
minimum
        threshold levels.
        Fixes #336336.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.