[gstreamer-bugs] [Bug 336898] Port musicbrainz/trm plugin to 0.10

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=336898
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62585|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.2




------- Comment #2 from Tim-Philipp Müller  2006-05-03 11:29 UTC -------
Nice work, thanks for porting this!

Comitted to CVS with some clean-ups:

2006-05-03  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: James "Doc" Livingston  <doclivingston gmail com>

        * configure.ac:
        * ext/musicbrainz/Makefile.am:
        * ext/musicbrainz/gsttrm.c: (gst_trm_base_init),
        (gst_trm_class_init), (gst_trm_init), (gst_trm_setcaps),
        (gst_trm_chain), (gst_trm_emit_signature), (gst_trm_set_property),
        (gst_trm_get_property), (gst_trm_change_state), (plugin_init):
        * ext/musicbrainz/gsttrm.h:
          Port MusicBrainz TRM plugin (#336898).

(took the liberty to rename everything to gst_trm_ in the process, since the
element itself is called "trm" and the debug category is "trm" as well).

Some comments for future stuff:

 - gst_pad_get_peer (pad) and gst_pad_get_parent (pad)
   return a reference, so gst_object_unref() must be called on
   the returned object after that.

 - in a chain function you should always pass the return
   value of gst_pad_push() back to the caller/upstream.

 - when you throw an error with GST_ELEMENT_ERROR, you
   should also return GST_FLOW_ERROR in the chain function.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.