[gstreamer-bugs] [Bug 340608] New: leaking caps in padtemplate

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=340608
 GStreamer | gstreamer (core) | Ver: HEAD CVS

           Summary: leaking caps in padtemplate
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ensonic at sonicpulse.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


gst_static_pad_template_get() seems to leak the caps from the
gst_static_caps_get() call.

Out of curiosity wouldn't

gst_caps_make_writable()
be better that gst_caps_copy() and gst_caps_unref() ?

attached patch changes it to:

caps = gst_static_caps_get (&pad_template->static_caps);  
GST_PAD_TEMPLATE_CAPS (new) = gst_caps_copy (caps);  
gst_caps_unref (caps);

would this also work?

GST_PAD_TEMPLATE_CAPS (new) = gst_caps_make_writable (
    gst_static_caps_get (&pad_template->static_caps));


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.