[gstreamer-bugs] [Bug 340016] does not build on opensolaris, must always include config.h first

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=340016
 GStreamer | gstreamer (core) | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64482|0                           |1
        is obsolete|                            |
  Attachment #64482|commented-on                |obsolete
               Flag|                            |
  Attachment #64522|0                           |1
        is obsolete|                            |
  Attachment #64563|none                        |committed
               Flag|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
            Summary|gstreamer does not build on |does not build on
                   |opensolaris                 |opensolaris, must always
                   |                            |include config.h first
   Target Milestone|HEAD                        |0.10.6




------- Comment #10 from Tim-Philipp Müller  2006-05-04 15:22 UTC -------
James - what about the shell lines with $(FLEX_PATH) and $(BISON_PATH) - don't
we have to add '; \'  after those as well?


Committed your patch (without the win32/config.h bit though), thanks!

2006-05-04  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: James Andrewartha <trs80 at tartarus uwa edu au>

        * gst/gst.c:
        * gst/gstbus.c:
        * gst/gstclock.c:
        * gst/gstevent.c:
        * gst/gstformat.c:
        * gst/gstmessage.c:
        * gst/gstparse.c:
        * gst/gstquery.c:
        * gst/gstutils.c:
        * gst/parse/Makefile.am:
        * libs/gst/base/gstadapter.c:
        * libs/gst/base/gstbasesrc.c:
        * libs/gst/base/gstpushsrc.c:
        * libs/gst/base/gsttypefindhelper.c:
        * plugins/elements/gstfakesrc.c:
        * plugins/elements/gstidentity.c:
          Make sure gstprivate.h and/or config.h are
          always included first, otherwise some of our
          defines (like _FILE_OFFSET_BITS) might be
          redefined in the system headers. Fixes build
          on opensolaris (#340016).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.