[gstreamer-bugs] [Bug 331727] make probes and Ghostpads more elegant

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=331727
 GStreamer | gstreamer (core) | Ver: 0.10.x


Andy Wingo changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64877|none                        |needs-work
               Flag|                            |




------- Comment #12 from Andy Wingo  2006-05-08 08:59 UTC -------
The patch is incorrect wrt refcounts.

  while (GST_IS_GHOST_PAD (pad)) {
    if (was_ghost)
      gst_object_unref (pad);
    pad = gst_ghost_pad_get_target (GST_GHOST_PAD (pad));

You only have one reference on pad in the was_ghost==TRUE case, but you use its
value after dropping your reference. You would need to make a temp variable and
unref it after the get_target.

However this whole idea of including gstghostpad.h from within gstpad.c is
incorrect. GstPad should supply an interface general enough that gstghostpad
can implement this functionality on its own, without having to have gstpad.c
explicitly call out to it.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.