[gstreamer-bugs] [Bug 340859] [avimux] produces index with all frames marked as keyframes

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=340859
 GStreamer | gst-plugins-good | Ver: 0.10.3


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64938|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|avimux produces index with  |[avimux] produces index with
                   |all frames marked as        |all frames marked as
                   |keyframes                   |keyframes
   Target Milestone|HEAD                        |0.10.4




------- Comment #2 from Tim-Philipp Müller  2006-05-09 14:08 UTC -------
Oops, nice catch.

I think this is actually a bug in gst_buffer_make_metadata_writable() - fixed
in core CVS now:

 2006-05-09  Tim-Philipp Müller  <tim at centricular dot net>

       * gst/gstbuffer.c: (gst_buffer_make_metadata_writable):
         gst_buffer_make_metadata_writable() should maintain the
         buffer flags (those that make sense at least) (see #340859).


and committed to -good CVS as well:

 2006-05-09  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Mark Nauwelaerts  <manauw at skynet bet>

       * gst/avi/gstavimux.c: (gst_avi_mux_do_audio_buffer),
       (gst_avi_mux_do_video_buffer):
         Work around gst_buffer_make_metadata_writable() bug that
         results in avimux marking all frames in the index as
         keyframes (#340859).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.