[gstreamer-bugs] [Bug 340979] [id3demux] mp3 id3v2 TCON tag possible bug?

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=340979
 GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Comment #8 from Tim-Philipp Müller  2006-05-10 10:50 UTC -------
This seems to fix it, haven't double-checked with tags that have the genre
number as string in brackets though:


--- id3v2frames.c       28 Apr 2006 11:37:22 -0000      1.15
+++ id3v2frames.c       10 May 2006 10:48:57 -0000
@@ -627,7 +627,8 @@ id3v2_genre_fields_to_taglist (ID3TagsWo
           break;

         for (pos = 1; pos < len; pos++) {
-          if (tag_str[pos] == ')') {
+          if (tag_str[pos-1] >= '0' && tag_str[pos-1] <= '9' &&
+              tag_str[pos] == ')') {
             gchar *tmp_str;

             tmp_str = g_strndup (tag_str + 1, pos - 1);


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.