[gstreamer-bugs] [Bug 169936] [subparse] support for SAMI subtitles

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=169936
 GStreamer | gst-plugins-base | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65401|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[PATCH] [subparse] support  |[subparse] support for SAMI
                   |for SAMI subtitles          |subtitles
   Target Milestone|HEAD                        |0.10.8




------- Comment #29 from Tim-Philipp Müller  2006-05-15 09:43 UTC -------
Committed to CVS, thanks for the patch and sorry everything took so long:

 2006-05-15  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Young-Ho Cha <ganadist at chollian net>

       * gst/subparse/samiparse.c: (handle_start_font):
         Need to map "silver" colour explicitly.

 2006-05-15  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Young-Ho Cha  <ganadist at chollian net>

        * gst/subparse/Makefile.am:
        * gst/subparse/gstsubparse.c: (gst_sub_parse_dispose),
        (parser_state_dispose), (gst_sub_parse_data_format_autodetect),
        (gst_sub_parse_format_autodetect), (feed_textbuf),
        (gst_subparse_type_find), (plugin_init):
        * gst/subparse/gstsubparse.h:
        * gst/subparse/samiparse.c:
        * gst/subparse/samiparse.h:
          Add support for SAMI subtitles (#169936).

I've taken the liberty to split out the SAMI parsing code into a separate file
(I think in the long run it's more maintainable like that). Also, I've changed
the code to use a new media type application/x-subtitle-sami for SAMI subtitles
(this gives us more flexibility and among other things keeps open the option to
split the code into a separate plugin in case anyone ever thinks that that
should be done because of the libxml2 dependency etc.).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.