[gstreamer-bugs] [Bug 339520] [subparse] add "encoding" property

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=339520
 GStreamer | gst-plugins-base | Ver: 0.10.x


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64171|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|add encoding property in    |[subparse] add "encoding"
                   |subparse plugin.            |property
   Target Milestone|HEAD                        |0.10.8




------- Comment #2 from Tim-Philipp Müller  2006-05-17 17:55 UTC -------
Well, I don't really see how a property is more *end-user* friendly, since
end-users don't set properties on elements anyway, the application does that
(and normally the subparse element is autoplugged by decodebin or playbin
anyway, so even the application has a hard time doing this).

Nevertheless, let's add it, since this is the way we do stuff, and also that
way it shows up in gst-inspect and in the docs.


Committed with some changes:

 - the first property must have an enum value > 0, that's why there's
   usually an unused PROP_0 enum at the beginning of the properties
   enums list

 - the property should be G_PARAM_READWRITE, not just G_PARAM_WRITABLE
   (and you implement both as well, ie. there is a getter function)

 - used subparse->encoding rather than subparse->default_encoding, since
   it's not really the default, but a fallback in case the text is not
   UTF-8 (also, it's shorter).


 2006-05-17  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Young-Ho Cha  <ganadist chollian net>

        * gst/subparse/gstsubparse.c: (gst_sub_parse_dispose),
        (gst_sub_parse_class_init), (gst_sub_parse_init),
        (gst_sub_parse_set_property), (gst_sub_parse_get_property),
        (convert_encoding):
        * gst/subparse/gstsubparse.h:
          Add 'encoding' property (#341681).

        * gst/subparse/samiparse.c: (characters_sami):
          Output is pango markup, so we need to escape text
          between tags (#342143).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.