[gstreamer-bugs] [Bug 342097] [jpegdec] crash with attached JPEG file

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=342097
 GStreamer | gst-plugins-good | Ver: 0.10.x


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65691|none                        |committed
               Flag|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.4




------- Comment #3 from Tim-Philipp Müller  2006-05-22 15:31 UTC -------
Committed:

 2006-05-22  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/jpeg/gstjpegdec.c: (hresamplecpy1),
        (gst_jpeg_dec_decode_indirect), (gst_jpeg_dec_chain):
          Fix crashes when the horizontal subsampling is 1.
          Fixes #342097.


Ideally we should probably just be pushing buffers in the source format, so
that we don't need to do adjustments like this, however:

  - we still need fallback code for the case where we don't
    have a matching format (e.g. r_v != r_h)

  - more formats = more codepaths and more complexity =
    higher chance of gettings things wrong
    (like offsets/strides etc.)

  - in this particular case (r_v=1, r_h=1) the only matching
    YUV format we have seems to be AYUV, so we'd be push a
    bogus alpha plane and a format that most likely requires
    a colorspace conversion somewhere downstream anyway. That
    doesn't exactly seem worth the extra trouble.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.