[gstreamer-bugs] [Bug 342268] add 'subtitle-encoding' property in playbin plugin

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=342268
 GStreamer | gst-plugins-base | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66122|none                        |commented-on
               Flag|                            |




------- Comment #5 from Tim-Philipp Müller  2006-05-26 14:28 UTC -------
Thanks for the updated patch, some more comments:

(1)

> play_base_bin->subtitle_elements = g_slist_alloc ();

An empty GSList is simply NULL. What you are doing is allocate a single list
node with an unset/garbage data pointer, that's probably not what you want
here.

Without that, you should also be able to remove the

  if (!element)
    return;

check in set_encoding_element().


(2)
There should be some locking around play_base_bin->subencoding in the
element-added callback and the properties setter/getter.


(3)
In case ARG_SUBTITLE_ENCODING: it should be possible to set the subtitle
encoding back to NULL for 'back to default'.

Then in set_encoding_element(), you should use GST_STR_NULL(encoding) rather
than just 'encoding', since on some platforms/with some libc (notably win32)
printf might crash when it is asked to print a NULL string.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.