[gstreamer-bugs] [Bug 343122] [taglib][PATCH] new apev2mux element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=343122
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66338|0                           |1
        is obsolete|                            |
  Attachment #66340|0                           |1
        is obsolete|                            |




------- Comment #3 from Tim-Philipp Müller  2006-05-28 14:54 UTC -------
Created an attachment (id=66373)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=66373&action=view)
updated patch

After fixing the test case (it should actually check track number/count and
replagain stuff in _check_tags() - same bug as in id3v2mux test case), it
appears the replaygain tags should be REPLAYGAIN_FOO_BAR instead of
REPLAY_GAIN_FOO_BAR - sometimes unit tests are actually useful :)

Updated patch against gst-plugins-good:

 - fixed test case (see above)

 - fixed replay gain tags

 - handle TRACK_COUNT tag without TRACK_NUMBER tag

 - add code for ALBUM_VOLUME_NUMBER and COUNT (disabled for now,
   should also be added to the demuxer and the test case)

 - in ext/taglib/Makefile.am
     noinst_HEADERS = gsttaglibmux.h gstid3v2mux.h gstapev2mux.cc
   should be
     noinst_HEADERS = gsttaglibmux.h gstid3v2mux.h gstapev2mux.h


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.