[gstreamer-bugs] [Bug 343184] [PATCH] mpeg2enc ported to 0.10

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=343184
 GStreamer | gst-plugins-bad | Ver: 0.10.3





------- Comment #5 from Mark Nauwelaerts  2006-05-29 20:20 UTC -------
> ext/Makefile.am needs patching too.

Oops, indeed, probably overlooked this somehow because mine also includes a
change for mplex ;)

> > Also note that the stock mjpegtools-1.8.0 does not seem to install
> > the header file mpeg2enc/mpeg2syntaxcodes.h, which gives rise to
> > compiler complaints  if not manually catered for.
> 
> What do you mean by 'if not manually catered for'? How do you cater for it?

I got the problem above as well; compilation (at least gcc3 ;)) succeeds after:
- a bit of a hack in configure.ac (which is included in the patch)
- copying the mpeg2enc/mpeg2syntaxcodes.h in the 1.8.0 tarball to the include
dir (e.g) /usr/[local/]mjpegtools/mpeg2enc

> With your patch mpeg2enc compilation on my dapper system (and libmjpegtools
> 1.8.0)  fails because of 'ratectl.hh: mpeg2syntacodes.h - no such file or
> directory' for me (didn't notice before because of the above ;))
Agreed, the above 'catering' should help :)

> Was your patch supposed to include that file?
It is part of mjpegtools, so I suppose not (??)
[the problem in mjpegtools is that either it is mentioned as an 'include' too
many (in ratectl.hh), or classifying it as noinst_HEADERS is a slip]
However, I was/am planning to come up with a patch for this problem (and the
'config.h' one) and put it here (and/or sourceforge, see below).

> (and is upstream aware of this bug?)
If by 'upstream' is meant the mjegtools project (maintainers), then yes.
At least, the mpeg2syntaxcodes.h thingy is entered as a bug on sourceforge.
Fix seems to be planned as part of a (larger) header repartitioning (work in
progress), but a small fix/patch (if possible) in the meantime may be helpful
(for smoother sailing in compilation at least ;) ).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.