[gstreamer-bugs] [Bug 352605] [PLUGIN-MOVE] please move wavpack to -good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=352605

  GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #2 from Stefan Kost (gstreamer, gtkdoc dev)  2006-11-07 07:55 UTC -------
code looks very clean.

one minor cosmetic change for all:
Code from gstwavpackdec.c::gst_wavpack_dec_init() and
gst_wavpack_dec_change_state() can be factored out into
gst_wavpack_dec_reset().
Same for encoder and parse.

In encoder:
* in gst_wavpack_enc_base_init make ElementDetails const
* in gst_wavpack_enc_sink_set_caps() move error handing to the end
* can you add enums for enc_mode, enc_correction_mode, joint_stereo_mode then
you can use them instread on 0,1,2,3,... in gst_wavpack_enc_mode_get_type(),
gst_wavpack_enc_correction_mode_get_type(),
gst_wavpack_enc_joint_stereo_mode_get_type() and in e.g.
gst_wavpack_enc_set_wp_config()
* wouldn't it make sense to add a gboolean return to
gst_wavpack_enc_rewrite_first_block() ?

<superminornictpick>
in the doc sections you write 'wavpackdec', but 'Wavpackenc' and
'Wavpackparse'. What about 'WavPackDec' or 'WavpackDec' (and likewise for the
others).
</superminornictpick>


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email