[gstreamer-bugs] [Bug 356692] wavparse drops final sample in most files

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=356692

  GStreamer | gst-plugins-good | Ver: HEAD CVS


René Stadler changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74648|0                           |1
        is obsolete|                            |




------- Comment #5 from René Stadler  2006-11-16 17:37 UTC -------
Created an attachment (id=76710)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=76710&action=view)
Ceiling division in duration and offset calculation (2)

The first possible solution I mention in comment #3 is wrong, it would not work
for 8-bit mono pcm files.

Attached is an improved patch.  It does the same thing as the old one, but is
more correct.  Instead of adding denominator - 1 before dividing (which is
awkward to do in conjuction with overflow prevention), this uses the modulo
operation (in an overflow safe manner) to find out if the division has a
remainder.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email