[gstreamer-bugs] [Bug 377306] gnome-volume-control does not localize the label.

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=377306

  GStreamer | gst-plugins-base | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76898|none                        |rejected
               Flag|                            |




------- Comment #6 from Tim-Philipp Müller  2006-11-20 12:29 UTC -------
Some comments:

 - GstMixerTrack is public API. You can't just add a new member to
   the structure somewhere in the middle, this breaks ABI compatibility.
   If at all, this needs to be added to the end with the padding reduced
   (however, we don't seem to have any padding in this case, not sure
   if we could still add an extra member or not).

 - _if_ you add a new member like label_l10n and then change
   gnome-volume-control etc. to use it you should really also
   make sure that all other GstMixerTrack users (alsamixer, ossmixer, etc.)
   set this new member, otherwise gnome-volume-control will no longer
   show any labels for alsa/oss users, will it?

 - in your patch to gst-mixer/src/track.c: why is the l10n label used only
   for vertical orientations, but not horizontal ones? (admittedly the
   translation marker in the code for the horizontal label doesn't really
   make a whole lot of sense, but still).

 - where in the code does gnome-volume-control compare mixer track
   labels with device names?


As far as I know alsa mixer track labels are localised by default, so if it is
possible at all it would be great if the same could be done for the sun audio
mixer tracks (ie. just localising mixertrack->label directly instead of adding
a new struct member for this).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email