[gstreamer-bugs] [Bug 380129] New: gst_plugin_feature_load doesn't consistently ref a returned object

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=380129

  GStreamer | gstreamer (core) | Ver: HEAD CVS

           Summary: gst_plugin_feature_load doesn't consistently ref a
                    returned object
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: thaytan at mad.scientist.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


At the moment, gst_plugin_feature_load only refs the returned object the first
time it is loaded, not if it is already loaded, despite what the documentation
says. 

Fortunately, this is compensated at the moment by the fact that noone unrefs
the returned object. *Un*fortunately, at the end of the day this means we leak
plugin features when closing down, which makes me sad.

Attaching a patch which makes gst_plugin_feature_load do what it is supposed
to, and fixes refcounting in the places it's used in the core.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email