[gstreamer-bugs] [Bug 380610] New: [rganalysis] Incorrect event handling

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=380610

  GStreamer | gst-plugins-bad | Ver: HEAD CVS

           Summary: [rganalysis] Incorrect event handling
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: mail at renestadler.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The rganalysis element from the replaygain plugin does not call BaseTransform's
base handler for the "event" vfunc.  I suppose this breaks QOS.  Should
BaseTransform be changed to do the push_event in the base handler, this would
have more severe consequences (there is a FIXME in the code that suggests
this).

I forgot to include the call to the base handler because it is the only vfunc
(besides src_event) that is not "hook-style" (the other base handlers do
nothing and are meant to be overridden completely).  As I don't have write
access to the repository, someone has to apply the single line fix I will
attach.  Sorry for the inconvenience.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email