[gstreamer-bugs] [Bug 348085] [PLUGIN-MOVE] move spectrum to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=348085

  GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #8 from Tim-Philipp Müller  2006-10-05 17:40 UTC -------
Since I've just by chance come across the spectrum code, some random comments:

 - the code looks messy in places, with lots of commented
   out stuff / left-over cruft

 - there's no locking being done anywhere whatsoever, that
   can't be right

 - weird GST_LOG stuff: what's with GST_LOG ("               hello")?

 - GST_LOG etc. used instead of GST_LOG_OBJECT

 - don't know if this has been discussed before, but since spectrum is
   now effectively a sink, would it make sense to derive it from
   GstBaseSink instead of GstBaseTransform?

 - I suppose the (IMHO somewhat awkward) thing about having a
   GST_TYPE_LIST of G_TYPE_UCHAR has been done with language bindings
   in mind? Any reason not to just use a GST_TYPE_BUFFER instead, which
   bindings should be able to wrap fine as well (if I'm not mistaken)?

 - if you eat all events you probably need to unref them if you want
   to avoid leaks


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email