[gstreamer-bugs] [Bug 359653] GStreamer Binary Registry patch
GStreamer (bugzilla.gnome.org)
bugzilla-daemon at bugzilla.gnome.org
Fri Oct 6 13:21:58 PDT 2006
Do not reply to this via email (we are currently unable to handle email
responses and they get discarded). You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=359653
GStreamer | gstreamer (core) | Ver: HEAD CVS
Stefan Kost (gstreamer, gtkdoc dev) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
------- Comment #5 from Stefan Kost (gstreamer, gtkdoc dev) 2006-10-06 20:21 UTC -------
some more comments:
#1: please add:
#define GST_CAT_DEFAULT GST_CAT_REGISTRY
to gstregistrybinary.c
#2: wouldn't it make more sense to use pascal style strings (16bit length,
followed by data). Thats the current stringspace usage.
name 17 / 256
description 289 / 1024
filename 61 / 256
version 9 / 64
license 7 / 256
source 21 / 256
package 38 / 1024
origin 50 / 1024
#3: use gtk-doc style comments (but start local docs with /* instead of /**
#4: use malloc not calloc if memory gets initialized anyway
#5: in gst_registry_binary_write_cache() you walk registry->plugins backwards
and use g_list_append in gst_registry_binary_save_plugin(). Can't we reverse
that?
#6: gst_registry_binary_get_binary_plugin() looks leaky / broken. At first you
once do g_free(plugin); and once gst_object_unref(plugin);. Next you leak all
strings on all those return -1
--
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
More information about the Gstreamer-bugs
mailing list