[gstreamer-bugs] [Bug 343348] [matroska] add support for vobsub subtitles

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=343348
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70222|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.5
            Version|0.10.6                      |HEAD CVS




------- Comment #7 from Tim-Philipp Müller  2006-09-04 16:30 UTC -------
Committed with only a few minor style-related changes:

 2006-09-04  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Frédéric Riss  <frederic.riss at gmail dot com>

        * gst/matroska/matroska-demux.c: (gst_matroska_track_free),
        (gst_matroska_demux_reset),
        (gst_matroska_demux_read_track_encodings),
        (gst_matroska_demux_add_stream), (gst_matroska_decode_buffer),
        (gst_matroska_demux_parse_blockgroup_or_simpleblock),
        (gst_matroska_demux_subtitle_caps):
        * gst/matroska/matroska-ids.h:
          Add support for VOBSUB subtitle tracks and zlib-compressed
          tracks. Make sure we start on a keyframe after a seek. (#343348)

Many thanks for the patch!


(In reply to comment #2)
> One last thing: while seeking with the patch applied, I get crashes in
> dvdsubdec. From time to time (but always while seeking), the element executes
> gst_dvd_sub_dec_merge_title() with a NULL dec->partialbuf. I don't know if 
> it's an issue in dvdsubdec or in my patch, any idea?

I've seen those as well, it was one of the reasons why I've set dvdsubdec's
rank to NONE for the time being. I'm fairly sure that's a dvdsubdec issue
though, since I've ran into it with dvddemux.



The more general playbin/Totem issue is already tracked in bug #350311, hence
closing this bug.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.