[gstreamer-bugs] [Bug 348085] [PLUGIN-MOVE] move spectrum to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=348085
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


René Stadler changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail at renestadler.de




------- Comment #1 from René Stadler  2006-09-10 02:53 UTC -------
Some problems I see with that code, ordered by relevance:

The dispose handler of GObjects must cope with being called multiple times. 
Set the pointers you g_free () to NULL afterwards.

You need to implement basetransform's event () vfunc and watch out for EOS. 
Perform what ever you do in stop () if you get one (see below).

The time interval property value is stored in gdouble instead of guint64, this
makes no sense.  Even if it was needed, the value is handled totally wrong.

Implement basetransform's stop () vfunc and use gst_adapter_clear () there
(instead of in start ()).  Also do this on EOS.

filter->width is set in _set_caps (), but never used (element supports 16 bit
only, with 16 bit depth only, so there is indeed no need to inspect the
configured width).

The code still uses GST_DEBUG in _transform_ip ().

In _init (), use "GST_MSECOND * 100" instead of "GST_SECOND / 10".

In _set_caps (), wanted = ..., use "sizeof (gint16)" instead of "2" for
clarity.

In _init (), g_malloc () is used and memset (..., 0, ...) directly after that. 
Just use g_malloc0 instead.

In _set_property (), case PROP_BANDS, just use g_realloc.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.