[gstreamer-bugs] [Bug 354908] videoflipping interface for v4l2src

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=354908
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Edgard Lima changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |edgard.lima at indt.org.br




------- Comment #1 from Edgard Lima  2006-09-13 21:22 UTC -------

Hi Stefan,

There are other controls:

V4L2_CID_AUDIO_VOLUME
V4L2_CID_AUDIO_BALANCE
V4L2_CID_AUDIO_BASS
V4L2_CID_AUDIO_TREBLE
V4L2_CID_AUDIO_MUTE
V4L2_CID_AUDIO_LOUDNESS

  those I think we could handle with GstMixerInterface, right?

for:

V4L2_CID_HFLIP
V4L2_CID_VFLIP
V4L2_CID_HCENTER
V4L2_CID_VCENTER

We could handle using the interface you proposed, but I rather like to use
something more generic. I'll explain bellow:

I have seen v4l2 devices having the following PRIVATE controls: Auto Luminace
Control [false-true], Horizontal Edge Enhancement [0-255], Vertical Edge
Enhancement [0-255], Lens Shading Compensation [0-63], Maximum Exposure Time
[0-3]

In addition to that, controls can be
V4L2_CTRL_TYPE_INTEGER - a range of values;
V4L2_CTRL_TYPE_BOOLEAN - true or false;
V4L2_CTRL_TYPE_BUTTON - You just set it to perform an action (doesn't make
sence to query its value);
V4L2_CTRL_TYPE_MENU - A enumeration of values.

I really like how v4l2 enumerates its controls.

So my proposal would be to create a interface called GstControl and
GstControlItem (like GstColorBalance and GstColorBalanceChannel) having id,
type(int, bool, button, enum), name, min, max, step, default_val, category (see
bellow)

And GstControlMenuItem having id, index, name.

About category: GstControlItem category could be one of "ColorBalance",
"Audio", "VideoLayout" and "Others".

...I don't know...it would make GstColorBalance obsolete. What about
GstMixerInterface ?

- - - - - - - - - - - - - - - - - - - 

Humm....I don't know, may be your approach is better. We could have a
GstVideoLayout interface and also a GstControl interface (just like I explained
above. This way, we could have GstColorbalance for known V4L2_CID_ (like
V4L2_CID_CONTRAST), GstMixer for known V4L2_CID_AUDIO_ (like BASS),
GstVideoFlip/Layout for (HCENTER, VCENTER, HFLIP, VFLIP) and GstControl for
PRIVATE ones.

It would be good to ask to Thomas and Wingo too.

What do you think?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.