[gstreamer-bugs] [Bug 354773] xvimage assumes that XV_COLORKEY can be set in RGB888 format

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=354773
 GStreamer | gst-plugins-base | Ver: HEAD CVS


Daniel Stone changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel at fooishbar.org




------- Comment #6 from Daniel Stone  2006-09-19 17:12 UTC -------
NACK to the patch in comment #4.  switching based on the display's depth is
bogus, as it's perfectly common to have an RGB565 display that still expects a
colour key in RGB888.  indeed, the only reason we never hit this is because
everyone else on the planet always takes an RGB888 colour key.

the only sane way to do this is to key off max_value on the XV_COLORKEY
attribute, which tells you exactly how many bits you have for the colour key.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.