[gstreamer-bugs] [Bug 347848] [id3v2mux] add support for DiscID tags

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=347848

GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|sound-juicer-               |gstreamer-
                   |maint at gnome.bugs            |bugs at lists.sourceforge.net
             Status|UNCONFIRMED                 |NEW
          Component|metadata                    |gst-plugins-good
     Ever Confirmed|0                           |1
            Product|sound-juicer                |GStreamer
          QAContact|sound-juicer-               |gstreamer-
                   |maint at gnome.bugs            |bugs at lists.sourceforge.net
            Summary|sound-juicer could write the|[id3v2mux] add support for
                   |DiscID in a tag             |DiscID tags
   Target Milestone|---                         |HEAD
            Version|unspecified                 |HEAD CVS




------- Comment #1 from Tim-Philipp Müller  2006-09-23 13:25 UTC -------
This should already be done automatically by GStreamer. The cd audio source
elements will calculate the various DiscIDs and send them as tags downstream,
so any tag writers should pick them up automatically and write them
automatically if they support those tags.

The reason this doesn't happen at the moment is that the usual GStreamer tag
writers don't support those DiscID tags yet.

This is fixed in gst-plugins-base CVS now for vorbis/speex/flac:

  2006-09-23  Tim-Philipp Müller  <tim at centricular dot net>

        * docs/libs/gst-plugins-base-libs-sections.txt:
        * gst-libs/gst/cdda/Makefile.am:
        * gst-libs/gst/cdda/gstcddabasesrc.c:
        (gst_cdda_base_src_base_init):
        * gst-libs/gst/cdda/gstcddabasesrc.h:
        * gst-libs/gst/tag/tag.h:
        * gst-libs/gst/tag/tags.c: (gst_tag_register_tags_internal),
        (gst_tag_register_musicbrainz_tags):
          Move GST_TAG_CDDA_* tags into libgsttag and make libgstcddabasesrc
          depend on libgsttag. This is required so we can extract/read tags
like
          DISCID without depending on libgstcddabasesrc (which used to register
          them).

        * gst-libs/gst/tag/gstvorbistag.c:
          Add vorbiscomment mapping for CDDB_DISCID and MUSICBRAINZ_DISCID
          tags (also see #347848).

        * ext/vorbis/vorbisenc.c: (gst_vorbis_enc_metadata_set1):
          Log vorbis comments we are actually writing. Const-ify array.


Still needs fixing for our ID3v2 tag writer (id3v2mux/taglib), hence moving bug
over to GStreamer.

Don't know what the most common way is to put these disc ID tags into ID3v2
tags though.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.