[gstreamer-bugs] [Bug 358156] New: in udpsrc.c gst_udpsrc_create function read command could loop

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=358156

GStreamer | gst-plugins-good | Ver: HEAD CVS

           Summary: in udpsrc.c gst_udpsrc_create function read command
                    could loop
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: hexa00 at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The problem was that to check if there was any command left of the pipe the
result of the read was compared with < 0 when read can return 0 and have no
more data (-1 is an error)

See from the man : " If count is zero, read() returns zero and has no other
results." ... " On  success,  the  number of bytes read is returned (zero
indicates end of file "

So I modifded the 

 READ_COMMAND (udpsrc, command, res);
          if (res < 0) {
            GST_LOG_OBJECT (udpsrc, "no more commands");
            /* no more commands */
            break;
          }

with a res <= 0


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.