[gstreamer-bugs] [Bug 413705] gst-plugins-good contails GPL'ed libcdio plugin

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=413705

  GStreamer | gst-plugins-good | Ver: HEAD CVS




------- Comment #7 from Brian Cameron  2007-04-11 03:55 UTC -------
Created an attachment (id=86150)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=86150&action=view)
patch with a fix


This patch just modifies the gst_cddasrc_read_sector function so instead of
calling calloc like this:

   if ((buf = calloc (1, len))) != NULL) { 

It calls it like this:

  if ((buf = calloc (1, (sizeof (void *) * len))) != NULL) { 

This fixes a core dumping issue on Sparc, where it was crashing because later
on in the function the gst_buffer_new_and_alloc function was reading into
uninitialized memory since the allocated buffer wasn't really long enough.

This code has been soaking in OpenSolaris for a few weeks now, and aside from
this issue, it seems to be working great, fyi.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=413705.