[gstreamer-bugs] [Bug 421543] [GstPad] Doesn't check if pad accepts caps after caps change

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=421543

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #15 from Sebastian Dröge  2007-04-12 15:34 UTC -------
I can't imagine any unpleasant side-effects but I'm working on a patch that
fixes the other bug too. It is based on this one though.

The additional things in the new patch will be:
a) accept_caps being called in set_caps IF there is a pad template for this
pad. Only in this case it makes sense to verify if the caps that are set are
valid and no unit test would break.

b) Set the caps on all output buffers in pad_push, etc. This will really fix
the second bug (see the "caps_changed" logic in 4 places).

a) might not be necessary, b) would be only a very low performance degration so
it might be better to only do b) for now (additional to the current patch).

What do you think?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=421543.