[gstreamer-bugs] [Bug 466442] amrnbenc has not properties to add header and select band mode

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=466442

  GStreamer | gst-plugins-ugly | Ver: 0.10.6

Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim.taymans at gmail.com
  Attachment #93615|none                        |committed
               Flag|                            |




------- Comment #2 from Wim Taymans  2007-08-16 14:50 UTC -------
Applied and cleaned up the property part.

For the addition of the header I would prefer to have a separate muxer element
(like there is a demuxer). The reason being that it would then become possible
to add the header to an already encoded file without a header (like making a
standalone file from AMR in a container).

        Patch by: Daniel Charles <dcharles at ti dot com>

        * ext/amrnb/amrnbenc.c: (gst_amrnbenc_bandmode_get_type),
        (gst_amrnbenc_set_property), (gst_amrnbenc_get_property),
        (gst_amrnbenc_base_init), (gst_amrnbenc_class_init),
        (gst_amrnbenc_chain), (gst_amrnbenc_state_change):
        * ext/amrnb/amrnbenc.h:
        Add property to select the BandMode of the AMR encoder.
        See #466442.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=466442.