[gstreamer-bugs] [Bug 501562] New: [switch] bogus locking order

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=501562

  GStreamer | gst-plugins-bad | Ver: HEAD CVS
           Summary: [switch] bogus locking order
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: wingo at pobox.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The code in gstswitch.c appears to have a locking order of OBJECT_LOCK,
SWITCH_LOCK. This is bogus. Although the code attempts to get this right, there
are still some errors like in the release_request_pad function:

  GST_OBJECT_LOCK (gstswitch);
  gstswitch->nb_sinkpads--;
  GST_SWITCH_LOCK (gstswitch);
  if (gstswitch->active_sinkpad == pad) {
    gst_object_unref (gstswitch->active_sinkpad);
    gstswitch->active_sinkpad = NULL;
    if (gstswitch->nb_sinkpads == 0) {
      GstIterator *iter =
          gst_element_iterate_sink_pads (GST_ELEMENT (gstswitch));
      gpointer active_sinkpad_store = (gpointer) gstswitch->active_sinkpad;

The proper solution is to make the locking order SWITCH_LOCK, OBJECT_LOCK.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=501562.