[gstreamer-bugs] [Bug 502497] [subparse] SubRip subtitles starting from 0 not recognised

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=502497

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #100583|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|SubRip subtitles starting   |[subparse] SubRip subtitles
                   |from 0 not recognised       |starting from 0 not
                   |                            |recognised




------- Comment #2 from Tim-Philipp Müller  2007-12-08 18:40 UTC -------
Thanks, should be fixed now:

 2007-12-08  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Robin Stocker <robin dot stocker at gmx dot ch>

        * gst/subparse/gstsubparse.c: (gst_sub_parse_data_format_autodetect):
          Some .srt files start with chunk number 0 and not chunk number 1,
          recognise and accept those as well (fixes #502497).

        * tests/check/elements/subparse.c: (srt_input), (srt_input0),
          (test_src):
          Add unit test for the above.

(I modified the patch slightly: it should be enough, and overall clearer, to
just change [1-9] to [0-9].)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=502497.