[gstreamer-bugs] [Bug 503231] Change to GST_BUFFER_FLAG_GAP meaning can break with basetransform elements

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=503231

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Stefan Kost (gstreamer, gtkdoc dev) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100819|none                        |reviewed
               Flag|                            |




------- Comment #4 from Stefan Kost (gstreamer, gtkdoc dev)  2007-12-12 12:31 UTC -------
Looks good! 2 minor things.

1.) The docs for gst_base_transform_set_gap_aware
  "If @gap_aware is %TRUE subclasses will get output buffers with the"
should say:
  "If @gap_aware is %TRUE subclasses might get output buffers with the"
or even better:
  "If @gap_aware is %FALSE (as it is by default) subclasses will never get
output
   buffers with the"

2.) Whatfor do we need gst_base_transform_is_gap_aware?
Elements only need to tell basetransform. Should anyone else need to know
wheter they can optimize or not?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=503231.