[gstreamer-bugs] [Bug 504040] gst_element_send_event() does not pass events to default event handler if the overloaded handler did not handle them

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=504040

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk




------- Comment #2 from Tim-Philipp Müller  2007-12-17 13:45 UTC -------
Since we don't have flow returns for the event functions yet, the semantics of
this are a bit screwy - it's hard to differentiate between 'baseclass wants to
just drop the event' and 'baseclass pushed it, but downstream returned FALSE'
etc. There are one or two similar bugs about this things in other contexts
IIRC.

I'm not really convinced changing the semantics of this now is a good idea. 
The derived class can always chain up in cases where we think it makes sense
though.

As far as the specific case of gst_element_send_event(source,
gst_event_new_eos()) goes: I'm not sure if if letting the app push a serialised
event from the app thread is a good idea, since this may block under some
circumstances.  I think it should be done like the FIXME in gstbasesrc.c
suggests, ie. queued and then handled from the streaming thread (pushing an EOS
event is not really the same as 'performing eos logic' in all cases).


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=504040.