[gstreamer-bugs] [Bug 442034] [avi] add support for subtitle streams (GAB2)

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=442034

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101125|none                        |accepted-commit_now
               Flag|                            |




------- Comment #9 from Tim-Philipp Müller  2007-12-17 14:32 UTC -------
Looks good enough to commit (I'd keep it at rank NONE until the last issues are
ironed out and seeking works right), provided the unit test passes and is
valgrind-clean (make elements/avisubtitle.valgrind).

Just a few more comments:

 - in gst_avi_subtitle_utf8_file: you probably meant file[0] == 0xef,
   not file[0] = 0x0ef (best to get rid of the parentheses around the
   individual comparisons, so things like this get caught by the compiler).

 - I'd probably do some kind of detect_encoding() function that skips
   any BOM and returns an encoding string, and then use g_convert()
   with that.  Alternatively, it's worth using g_utf8_validate()
   when assuming UTF-8 encoding (this can be done after committing)

 - in gst_avi_subtitle_chain: won't g_utf16_to_utf8() assume the
   byte order of the UTF-16 input is native byte order? In other
   words: will this work right on big endian systems given that
   the input is (I guess) UTF-16LE?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=442034.