[gstreamer-bugs] [Bug 500150] [filesink] add property to enable buffering via setvbuf()

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=500150

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100681|none                        |committed
               Flag|                            |
 Attachment #100682|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.16




------- Comment #14 from Wim Taymans  2007-12-24 19:15 UTC -------
Commited with these changes:

  - buffer-mode can be controlled. This allows for unbuffered, line and fully
    buffered modes. The default is to not configure any buffering with setvbuf
    and just leave the defaults (which seems to be 4K buffering for files, line
    buffering for teminals, unbuffered for stderr).
  - buffer-size in bytes. There is a default of 64K buffer, enabled when
    buffer-mode is set to the required kind of buffering.
  - the check for getpagesize in configure.ac was not needed anymore.

This should allow you to configure all options of setvbuf.


        Based on Patch by: Laurent Glayal <spglegle at yahoo dot fr>

        * configure.ac:
        Check for stdio_ext.h for the filesink changes.

        * plugins/elements/gstfilesink.c: (buffer_mode_get_type),
        (gst_file_sink_class_init), (gst_file_sink_init),
        (gst_file_sink_dispose), (gst_file_sink_set_property),
        (gst_file_sink_get_property), (gst_file_sink_open_file),
        (gst_file_sink_close_file):
        * plugins/elements/gstfilesink.h:
        Add two properties to control the buffering mode and size.
        API: GstFileSink::buffer-mode
        API: GstFileSink::buffer-size


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=500150.