[gstreamer-bugs] [Bug 356882] [PLUGIN-MOVE] synaesthesia has been ported

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=356882

  GStreamer | gst-plugins-ugly | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #1 from Tim-Philipp Müller  2007-02-08 20:07 UTC -------
Just had a very quick look, so just some random notes:

 - has no docs

 - has no tests

 - Makefile.am lacks a bunch of CFLAGS and LIBS stuff for
   libgstbase and libgstaudio/video

 - this crashes for me:
   gst-launch-0.10 audiotestsrc ! audioconvert ! synaesthesia ! ximagesink
   (seems to work with ffmpegcolorspace ! xvimagesink though)

 - the license in the header says LGPL but in DEFINE_PLUGIN
   macro "GPL" (was probably there before, but still)

 - the _CLASS macro casts to an instance structure, not to
   the class structure

 - gst_set_foo_func() should be used with GST_DEBUG_FUNCPTR

 - the _setcaps() function returns GST_PAD_LINK_* values instead
   of TRUE/FALSE as it should

 - in _setcaps() you leak object references when you return early

 - _init() should use pad_new_from_static_template() (don't remember
   when that was added, should be changed to use that though)

 - in _chain(), if pad_alloc_buffer() fails, you leak an object
   reference

Looks like it needs some more work to me.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email