[gstreamer-bugs] [Bug 407057] [wavparse] leaks contents of every buffer pushed when in push mode

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=407057

  GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82381|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.6




------- Comment #3 from Tim-Philipp Müller  2007-02-12 23:27 UTC -------
Thanks for the patch! Committed this with the following changes:

 - use gst_adapter_take_buffer()

 - gst_wavparse_parse_file_header() takes ownership of the
   buffer passed as far as I can see, so no need to unref
   buffer afterwards (in fact, I think it would lead to
   double frees)

 2007-02-12  Tim-Philipp Müller  <tim at centricular dot net>

        Based on patch by: Jonathan Matthew  <jonathan at kaolin wh9 net>

        * gst/wavparse/gstwavparse.c: (gst_wavparse_parse_stream_init),
        (gst_wavparse_stream_data):
          Fix massive memory leak when operating in streaming mode due to
          GST_BUFFER_MALLOCDATA() not being set on newly-created buffers.
          Fixes #407057.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email