[gstreamer-bugs] [Bug 354174] [PATCH] add REAL support by using the proprietary drivers

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=354174

  GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #34 from Edward Hervey  2007-01-01 23:06 UTC -------
Lutz, a few additional changes that would be nice to see:

_ use proper debug level. Use ERROR/WARNING where it's needed. This will make
the message appear on standard output for example.
_ you said you renamed the plugin/element, but there's no mention of that in
your patch.
_ as for splitting the audio and video decoder, maybe it would be good to split
up the work in more files like:
* realplugin.c : contains the GST_PLUGIN_DEFINE and all plugin-global code
* gstrealvideo.[ch] : contains the RealVideo plugin
* gstrealaudio.[ch] : contains the RealAudio plugin

  You had initially a test which I didn't include, since 1/ we put tests in
separate directories (gst-plugins-bad/tests/), 2/ it requires human interaction
and 3/ it depends on a network location which might change in the future. For
decoders, it's really hard to make unit tests. We already have the
gst-media-test which you could try with several files to serve such purposes.

The plugin is currently in gst-plugins-bad/gst/real/ btw.

Anyway, really nice work. Quite comforting to see all these .rm files show up
green in the gst-media-test now :)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email