[gstreamer-bugs] [Bug 339326] pads not set to FLUSHING when created

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=339326

  GStreamer | gstreamer (core) | Ver: HEAD CVS


Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com




------- Comment #4 from Jan Schmidt  2007-01-05 18:52 UTC -------
You missed a case, that is now impossible to do correctly:

  * Running element adds a SINK pad to itself (e.g: a Muxer with request pads,
or multiqueue).
  * By the new logic, an element must do gst_pad_set_active before adding the
pad.
  * Activating the pad causes the _activate handlers to be called, for stuff
like activating pull mode when it can, but the pad isn't linked to anything and
has no parent yet because it hasn't been added to the element.

The same thing applies to SRC pads with activate handlers, but those aren't
common.

I think that instead of warning when a flushing pad is added to a running
element, the pad should just be activated, because both
add-to-element-then-activate or activate-then-add-to-element are both wrong -
the activation needs to happen atomically when adding the pad.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email