[gstreamer-bugs] [Bug 393427] error/warnings when compiling with mingw

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=393427

  GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
            Summary|[gst-plugins-good]          |error/warnings when
                   |error/warnings when         |compiling with mingw
                   |compiling with mingw        |




------- Comment #3 from Tim-Philipp Müller  2007-01-06 12:10 UTC -------
Cool, thanks for the patch. May I suggest the following changes though? :)

 - if the libjpeg header file says 'boolean', then the functions
   should probably return boolean on all systems, not only on win32
   (and even if different types were required it would be nicer to
   use a define or typedef IMHO)

 - please don't put #ifdef around GST_LOG statements for int vs long,
   just pick one of %ld or %d and add a cast

 - the printf format for gulong is %lu not %lud


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email