[gstreamer-bugs] [Bug 392393] [API] add libgstbaseutils library for missing plugins messages and unified descriptions

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=392393

  GStreamer | gst-plugins-base | Ver: HEAD CVS


Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com




------- Comment #5 from Jan Schmidt  2007-01-08 17:34 UTC -------
In general, this looks pretty promising.

A few notes:

* base-utils.h should include descriptions.h and missing-plugins.h as
<gst/utils/base-utils.h>, because they're all installed headers

* Why force the user to include descriptions and missing-plugins via
base-utils?

* The descriptions.h functions, look good... but is it a good idea to drop the
base_utils bit and use the 'GstElement' namespace for the
gst_element_post_missing_ functions? I don't know if this has any implications
for autogenerated bindings. They're not GstElement member methods, so I don't
think they should use the namespace, but...
gst_base_utils_element_post_missing_* is just getting silly. Leaving out bad
too thought. Perhaps we can come up with shorter function names for those
methods, or alternatively, remove the post_element part of the functionality to
put the methods into the gst_missing_plugin_message namespace, and make the
caller then do gst_element_post () after. Bah, I dunno :) It's mostly the
bindings part that bugs me - these functions shouldn't/can't end up as methods
of GstElements in Python/C#/Perl/C++ and friends, so they shouldn't go into tat
namespace. 

* I'm not sure about 'utils/' as an include path, but I can't think of any real
objection except that it's more generic than our existing gst/ subdir examples:
audio, base, cdda, check, controller, dataprotocol, floatcast, interface, net,
netbuffer, riff, rtp, tag, video

* Still needs docs hooks in the sections.txt file.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email