[gstreamer-bugs] [Bug 397810] [typefinding] .vob file: could not determine type of stream

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=397810

  GStreamer | gst-plugins-base | Ver: 0.10.11


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80583|0                           |1
        is obsolete|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.12




------- Comment #4 from Tim-Philipp Müller  2007-01-19 12:24 UTC -------
Admittedly the implementation is a bit crude, but it's better than doing a new
peek for each offset. I suppose you had something a bit more sophisticated in
mind like what we're doing for mpeg1?

I've committed this for now, but changed it to accept smaller sizes as well: 21
bytes is the new minimum size now, I think that should be fine even for
buffer/push-mode based typefinding. 

  2007-01-19  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
          Small mpeg2 system stream typefinding improvement: make typefinder
          probe a bit into the stream instead of just looking for a marker
          at the beginning. Fixes #397810.

I guess the main worry are potential false positives, but since we're using
such a low probability when suggesting the caps, almost all other typefinders
should trump us, at least after this follow-up:

  2007-01-19  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
          Lower probability a bit if the marker isn't right at the start,
          to decrease the chance of false positives.

Feel free to replace with something better when you get around to it :)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email