[gstreamer-bugs] [Bug 398033] [audioconvert] support more than 8 channels

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=398033

  GStreamer | gst-plugins-base | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81057|0                           |1
        is obsolete|                            |




------- Comment #12 from Tim-Philipp Müller  2007-01-26 16:10 UTC -------
Created an attachment (id=81273)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=81273&action=view)
New patch

Previous patch still has a problem: I just ran into this assertion with the
thehillshaveeyes trailer:

** CRITICAL **: gst_audio_get_channel_positions: assertion
`gst_value_array_get_size (pos_val_arr) == channels' failed

caps has 2 channels and a channel-position array with 8 channel positions.
Looks like somewhere (in transform_caps?) we manage to produce caps with a [1;
8] channel range AND channel-positions and the fixate function later fixates
the channel number on that later. The bug might have existed before but was
conveniently covered up by the fact that the fixate function stripped channel
positions in certain circumstances anyway, I think.

The updated patch removes channel-positions fields from the new output
structure in transform_caps() if setting a channel range on the copied
structure. This fixes problems if the input structure had 8 channels input.

Also added unit tests for this problem.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email