[gstreamer-bugs] [Bug 402393] [GstCollectPads] Allow elements to specify destroy notify for custom GstCollectData

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=402393

  GStreamer | gstreamer (core) | Ver: HEAD CVS


Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[gst_parse_launch] Leaking  |[GstCollectPads] Allow
                   |request pads                |elements to specify destroy
                   |                            |notify for custom
                   |                            |GstCollectData




------- Comment #3 from Sebastian Dröge  2007-01-30 19:41 UTC -------
Ok, it seems that this is in fact caused by the entries in GstOggPad that must
be freed but can't because of API limitations in GstCollectPads.

To allow elements to use custom GstCollectData with entries that must be freed
I propose the addition of a destroy notify for GstCollectPads which will be
called when the GstCollectData will be freed.

The public API additions are:
typedef void (*GstCollectDataDestroyNotify) (GstCollectData* data);

GstCollectData *gst_collect_data_add_pad_full (GstCollectPads * pads, GstPad *
pad, guint size, GstCollectDataDestroyNotify destroy_notify);

Everything is else private. Attached is a patch to implement this and a patch
to use this in oggmux.


The other two bugs are still relevant but not the cause of this one :)

a) is filed as bug #402562  b) as bug #402497


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email